Code completion doesn't work on the editor if the import is aliased

[clayberg]

[Luke]

Code completion doesn't work on the editor if the import is aliased.

E.g. import dom:html prefix html� html.document. doesn't offer completion.

////////////////////////////////////////////////////////////////////////////////////
Editor Version: 5382
////////////////////////////////////////////////////////////////////////////////////
OS: Mac OS X - x86_64 (10.7.3)
SDK installed = true
Dartium installed = true
////////////////////////////////////////////////////////////////////////////////////
.ast.DartUnit.accept(DartUnit.java:61)
       at com.google.dart.tools.core.internal.indexer.contributor.DartProcessor.process(DartProcessor.java:63)
       at com.google.dart.tools.core.internal.indexer.contributor.DartProcessor.processTarget(DartProcessor.java:87)
       at com.google.dart.indexer.index.IndexTransaction.indexTarget(IndexTransaction.java:115)
       at com.google.dart.indexer.workspace.index.WorkspaceIndexer.indexTarget(WorkspaceIndexer.java:475)
       at com.google.dart.indexer.workspace.index.WorkspaceIndexer.doIndexPendingFiles(WorkspaceIndexer.java:408)
       at com.google.dart.indexer.workspace.index.WorkspaceIndexer.indexPendingFiles(WorkspaceIndexer.java:235)
       at com.google.dart.indexer.workspace.driver.WorkspaceIndexingDriver$IndexingJob.run(WorkspaceIndexingDriver.java:60)
       at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

[clayberg]

Added Triaged label.

[stevemessick]

The TypeAnalyzer is always reporting <dynamic> type for anything with a prefix. I converted the clock sample to use a prefix for the html library. (attached) None of the identifiers that have a prefix get a more specific type than <dynamic>. The code is not "under construction"; it is finished and runs fine.

---

Attachment:
clock.zip (45.42 KB)

---

Set owner to [email protected].

[DartBot]

This comment was originally written by [email protected]

---

This fixes the dartc side and adds code for the completion engine that can work, but I'm afraid the completion side needs more work.

https://chromiumcodereview.appspot.com/10006030

[DartBot]

This comment was originally written by [email protected]

---

FYI, my repro case that captures one scenario:

$ cat library.dart
#library("library");

class library{
  int instanceField;
  void instanceMethod() {}
  static int staticField;
  static void staticMethod() {}
}

$ cat prefix-completion.dart
#import("library.dart", prefix : "prefix");

main() {
  prefix.library. // cursor here
  print("field is ${prefix.library.field}");
}

[DartBot]

This comment was originally written by [email protected]

---

r6272. dartc change is in. I'm moving over to Steve to finish the job or determine if what's there is good enough.

---

Set owner to @stevemessick.

[stevemessick]

We're making progress but not quite there yet. I'm running into a problem on line 1226 or Resolver.dart on the following code:

#import('dart:html', prefix: 'html');
f() {var x=new html.Element}

The identifier "html" gets dynamic type. I don't think the resolver should get to line 1226 in this case.

---

Set owner to [email protected].

[stevemessick]

Added Started label.

[stevemessick]

Marked this as blocking #2539.

[stevemessick]

Marked this as blocking #2616.

[stevemessick]

Marked this as blocking #2617.

[clayberg]

Added Fixed label.

[stevemessick]

Marked this as blocking #2617.