Skip to content

implement codegen of the new jsinterop in cpsir #24978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Nov 19, 2015 · 5 comments
Closed

implement codegen of the new jsinterop in cpsir #24978

sigmundch opened this issue Nov 19, 2015 · 5 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js

Comments

@sigmundch
Copy link
Member

No description provided.

@zoechi
Copy link
Contributor

zoechi commented Nov 19, 2015

May I ask what "nssa" means? I saw it a few times recently but have no clue what it is about.

@sigmundch
Copy link
Member Author

We have been doing some work to replace our ssa backend with the a cps-ir (continuation-passing-style IR), but we plan to do some refactoring changes that will remove the continuations from CPS-ir, which makes it more like a nested-ssa, or "nssa" for short :)

@zoechi
Copy link
Contributor

zoechi commented Nov 19, 2015

Never mind :D
Thanks anyway!

@sigmundch sigmundch added type-completeness P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 10, 2015
@sigmundch sigmundch changed the title implement codegen of the new jsinterop in nssa implement codegen of the new jsinterop in cpsir Feb 6, 2016
@sigmundch sigmundch self-assigned this Feb 10, 2016
@sigmundch
Copy link
Member Author

I'll be sending https://codereview.chromium.org/1688433006 out shortly. The following two tests are still failing:

js_typed_interop_side_cast_exp_test: It's not clear whether we want to continue supporting these semantics of allowing a side-cast. I haven't investigated what makes this behave different than SSA, but it's quite possible this seems to be breaking some assumptions in type-propagation.

js_typed_interop_test/static_method_tearoff_1: this seems broken due to an unrelated issue with tree-shaking. It might be related to #25720.

The CL also adds js_typed_interop_test/static_method_tearoff_2: to illustrate issue #25759.

@sigmundch
Copy link
Member Author

landed support in a0c438a. Closing since pending issues are tracked in the two bugs mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

2 participants