Skip to content

html/js_typed_interop_side_cast_exp_test failing on browsers #25937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whesse opened this issue Mar 7, 2016 · 5 comments
Closed

html/js_typed_interop_side_cast_exp_test failing on browsers #25937

whesse opened this issue Mar 7, 2016 · 5 comments
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-js-interop Issues that impact all js interop web-libraries Issues impacting dart:html, etc., libraries

Comments

@whesse
Copy link
Contributor

whesse commented Mar 7, 2016

The test html/js_typed_interop_side_cast_exp_test has started failing on all browsers using dart2js.

There is a discussion about this test with the cps_ir compiler, at #24978, but this is now failing with the non-cps compiler.

Suppressed in html/html.status.

@whesse whesse added web-dart2js web-libraries Issues impacting dart:html, etc., libraries P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Mar 7, 2016
@sigmundch sigmundch added web-js-interop Issues that impact all js interop and removed web-dart2js labels Mar 7, 2016
@sigmundch
Copy link
Member

Thanks Bill - yes this started failing with the new IDL roll in a similar way.

/cc @jacob314 - a general question remains on whether we want to support this experimental flag anymore (the test runs with a special flag). If not, we can delete the logic and the test.

@alan-knight
Copy link
Contributor

The general dart2js case started working with https://codereview.chromium.org/1811213002

I'm not sure if this should be closed or left open for the other questions.

@sigmundch
Copy link
Member

oh cool - then let's keep it. It makes sense that this was why it was failing: if we retain all native types for any reason, we don't tree shake code that this test otherwise expects to be gone.

This gives me some assurance that the dart:html annotations are likely complete now.

I'm inclined to keep the feature and test for now, it will help us figure out how things play out with strong mode in the future. At that point we will likely have only one mode, and we should be able to either make the default be the behavior with or without the flag.

@whesse
Copy link
Contributor Author

whesse commented Mar 18, 2016

It should be left open as long as the line referencing it is there in the status file. Is there a reason it wasn't changed in the status file?

@alan-knight
Copy link
Contributor

I did change the status file for dart2js. There was also a line for cps_ir that I left in, and it's skipped for Dartium by design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-js-interop Issues that impact all js interop web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

3 participants