Skip to content

ListMixin map/extend generic method comments #25408

Closed
@jmesserly

Description

@jmesserly

Right now they don't match the generic method comment signatures on Iterable, so this is an error:

class _FbList<E> extends Object with ListMixin<E> implements List<E>

Marked high-pri because this is easy to hit.

CC @leafpetersen, as this is related to SDK working with strong mode.

(this is sort of area-sdk, but only affects Analyzer strong mode. Not sure best way to label it.)

Activity

added
P1A high priority bug; for example, a single project is unusable or has many test failures
on Jan 12, 2016
leafpetersen

leafpetersen commented on Jan 13, 2016

@leafpetersen
Member

I fixed a bunch of these in the DDC copy of the sdk here: https://codereview.chromium.org/1554683002/

Lots of those SDK changes should get rolled into the main SDK.

jmesserly

jmesserly commented on Feb 2, 2016

@jmesserly
Author

I think @vsmenon is looking at this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1A high priority bug; for example, a single project is unusable or has many test failureslegacy-area-analyzerUse area-devexp instead.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @jmesserly@vsmenon@leafpetersen

      Issue actions

        ListMixin map/extend generic method comments · Issue #25408 · dart-lang/sdk