Skip to content

ListMixin map/extend generic method comments #25408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmesserly opened this issue Jan 12, 2016 · 2 comments
Closed

ListMixin map/extend generic method comments #25408

jmesserly opened this issue Jan 12, 2016 · 2 comments
Assignees
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@jmesserly
Copy link

Right now they don't match the generic method comment signatures on Iterable, so this is an error:

class _FbList<E> extends Object with ListMixin<E> implements List<E>

Marked high-pri because this is easy to hit.

CC @leafpetersen, as this is related to SDK working with strong mode.

(this is sort of area-sdk, but only affects Analyzer strong mode. Not sure best way to label it.)

@jmesserly jmesserly added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. analyzer-strong-mode labels Jan 12, 2016
@leafpetersen
Copy link
Member

I fixed a bunch of these in the DDC copy of the sdk here: https://codereview.chromium.org/1554683002/

Lots of those SDK changes should get rolled into the main SDK.

@jmesserly
Copy link
Author

I think @vsmenon is looking at this one.

@vsmenon vsmenon closed this as completed in 89ccefe Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants