Skip to content

Dart API test does not test native method lookup where it should. #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whesse opened this issue Apr 16, 2012 · 3 comments
Closed

Dart API test does not test native method lookup where it should. #2578

whesse opened this issue Apr 16, 2012 · 3 comments
Assignees
@turnidge
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-invalid Closed as we don't believe the reported issue is generally actionable P3 A lower priority bug or feature request
Milestone
M1

Comments

@whesse
Copy link
Contributor

whesse commented Apr 16, 2012

There is dead code, and untested functionality, because in
vm/runtime/dart_api_impl_test.cc, line 3458:
      " int method1(int i) native "ThrowException_native";"
declares a native method that is not called.
Thus, the native method resolver, and the native function, are also not called. There should be a line in the test that calls method1, I think.
@iposva-google
Copy link
Contributor

Removed the owner.

@iposva-google
Copy link
Contributor

Set owner to @turnidge.
Added this to the M1 milestone.
Added Accepted label.

@turnidge
Copy link
Contributor

turnidge commented Aug 3, 2012

It turns out that method1 is called by method2, so the test is working as intended. I agree that the names are misleading, so I have submitted a small change which renames the methods to make things more clear.

Added Invalid label.

@whesse whesse added Type-Defect P3 A lower priority bug or feature request area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-invalid Closed as we don't believe the reported issue is generally actionable labels Aug 3, 2012
@whesse whesse added this to the M1 milestone Aug 3, 2012
dart-bot pushed a commit that referenced this issue Aug 11, 2020
@sigurdm
Bump pub version
4b3db02 
> git log --oneline 04b054b62cc437cf23451785fdc50e49cd9de139..master
0d185a39 (HEAD -> master, origin/master, origin/HEAD) Push null-safety forwards to 2.11 (#2604)
56f9f27f Hide outdated --mode flag (#2603)
61ce6f81 Avoid double loop (#2605)
fa6e57d7 (disable_mixed_mode_validation) Fix outdated latest ordering (#2598)
6549e4aa Remove unused dependency from pubspec.yaml (#2592)
61543d07 Don't look for external package foo during testing (#2599)
590b448f Fixed license headers (#2595)
04e0601e Don't show entries for dev-dependencies in outdated --json --no-dev-dependencies (#2591)
8c3778c4 Configure GitHub move app (#2578)
eec7beca (top_level_command) Pass --(no-)sound-null-safety arg through to VM. (#2542)
152e4740 Warn about publishing in mixed mode (#2583)
0b7a3abe Removed april fools toys (#2325)
b74a5b73 Actually print hints (#2582)
8ec3a66d (pub2) Fix outdated --no-color (#2572)
7bb3d4e6 Use getSdkPath() in NullSafetyAnalysis (#2573)
3c578f24 Drop the "magic" package concept (#2577)
0e967ff0 Remove unused function (#2570)
988fefef Remove dependency overrides (#2568)

Change-Id: I58bf14234ed55bf9d825de60a40ded1d65281195
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158003
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turnidge turnidge

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-invalid Closed as we don't believe the reported issue is generally actionable P3 A lower priority bug or feature request
Projects
None yet
Milestone
M1
Development

No branches or pull requests
3 participants
@turnidge @whesse @iposva-google