Closed
Description
This is the analyzer-specific issue for #26996. That issue has the details.
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
{{ message }}
No one assigned
No type
No projects
No milestone
None yet
Activity
bwilkerson commentedon Aug 2, 2016
An initial implementation has been committed (https://codereview.chromium.org/2199323002/). The support is behind a flag, but there is no user-visible way to set the flag. Waiting on shared tests to make the feature user-visible.
bwilkerson commentedon Sep 6, 2018
@munificent Should this be closed?
eernstg commentedon Sep 7, 2018
I believe we should just get it done, and I don't yet see it working in
dartanalyzer(nor indartfor that matter). The spec update has not been landed yet, but it might be obvious (it's a 3 value domain, and it must shortcut, and it should be similar to other compound assignment operators ;-).bwilkerson commentedon Sep 7, 2018
There was support in analyzer behind a flag, but now that analyzer is on the fasta parser we've lost that support.
Is this an approved 2.1 language feature? I don't remember seeing it on the list, and we're getting very close to shipping, so I don't know that it's reasonable to add new changes at this date. Should we push this to 2.2?
eernstg commentedon Sep 7, 2018
I don't think it's on any short list, in particular certainly not 2.1, but I do think that the whole language team considers it to be an oversight that we don't yet have it, and it should just be done when possible. Don't we have a place for things that just need to be done, even though it won't be right now? ;-)
bwilkerson commentedon Sep 7, 2018
I'm happy to see us improve the quality of Dart, and I think this change would do so. To explain, I was reacting to "just get it done", which sounded like a call to immediate action. It's a non-zero amount of work, so I'd like to see it scheduled.
Perhaps we should create a "Dart2.2" milestone and add a meta issue to it to implement this in both analyzer and front_end.
eernstg commentedon Sep 7, 2018
Oops, those words were not well-chosen, sorry about that. I just meant that it would be a good idea to keep this issue open, as opposed to closing it and forgetting all about this topic (after all, it looks pretty much like an oversight that those forms of compound assignment are not supported). I think it would be a good idea to put it on such a milestone.
bwilkerson commentedon Sep 7, 2018
No problem :-)
Should we create an issue in the language repo?
4 remaining items