Skip to content

launch selection rather than last if selection is an application [+4] #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danrubel opened this issue Apr 25, 2012 · 10 comments
Closed

launch selection rather than last if selection is an application [+4] #2730

danrubel opened this issue Apr 25, 2012 · 10 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@danrubel
Copy link

[user feedback]
Newly created application not been set as main project/application. When I open a new application and try to run it using the green play button or “ctrl+r” the previous application is running, to run the application for the first time i need to right click and select run as---> dartium launch.

@danrubel
Copy link
Author

When the user clicks the "big green run button", I think that we should always "run last" unless the currently selected file is a Dart application (has a main() method) in which case we should run the selected application.

See also http://code.google.com/p/dart/issues/detail?id=2499

@clayberg
Copy link

Changed the title to: "launch selection rather than last if selection is an application [+1]".

@clayberg
Copy link

It is important that the green button behavior not be surprising. Always running last when you have selected a runnable Dart file is very surprising and unexpected.

@lukechurch
Copy link
Contributor

+1 Or after just creating a new project... Which will usually come to the same thing.

@clayberg
Copy link

[user feedback]

it would be nice if when we click Run, it runs the app where the cursor is positioned or the file that is being displayed in the editor rather than what was Run before


Removed Priority-Medium label.
Added Priority-High label.
Changed the title to: "launch selection rather than last if selection is an application [+2]".

@clayberg
Copy link

[hackathon comments]

(from jmesserly@ ... taking notes at hackathon) Launch configurations seem to require a lot of setup. It'd be much easier if a there was a "JS in browser" and "Dartium" option by default. Also everyone seems to be trying to right click on the entry point and run it. Finally sometimes "run" doesn't seem to have the right effect (or any effect). It's like it is stuck on an old configuration or something like that. (not sure the details of how to reproduce this one)


Changed the title to: "launch selection rather than last if selection is an application [+3]".

@danrubel
Copy link
Author

Howdy, editor folks. (KathyW here)

I'm starting to beef up the Dart Editor docs, but I don't know what to write about launches. The behavior isn't what I expected. Here's what happened:

  1. I downloaded a fresh copy of Dart Editor today. (I did not install this copy on top of another one.)
  2. I clicked a sample (sunflower) to open it.
  3. I executed the sample by clicking the Run button. Success.
  4. I probably clicked Manage Launches to check the state of checked mode and debugging.
  5. I created a server app. Clicking the Run button DOESN'T RUN IT. Instead, it runs the sunflower app.

I don't know how to get the server app to run, other than painfully creating a new launch for it.

Another surprise. CHECKED MODE is still off. For some reason, I thought it was now on by default. I guess only debugging is on by default.

What's the story on launching apps (aside from the first app)?

Thanks,

-k-
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 6943
////////////////////////////////////////////////////////////////////////////////////
OS: Mac OS X - x86_64 (10.6.8)
SDK installed = true
Dartium installed = true
////////////////////////////////////////////////////////////////////////////////////
<no log file available>


Changed the title to: "launch selection rather than last if selection is an application [+4]".

@keertip
Copy link
Contributor

keertip commented Apr 30, 2012

As per all the feedback, changing Run button behavior to

  • Run selection if it can be launched - either a browser or server app
  • If not, run last launched
    Added Started label.

@keertip
Copy link
Contributor

keertip commented Apr 30, 2012

Issue #2499 has been merged into this issue.

@keertip
Copy link
Contributor

keertip commented May 1, 2012

@danrubel danrubel added Type-Enhancement P1 A high priority bug; for example, a single project is unusable or has many test failures labels May 1, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
dart-bot pushed a commit that referenced this issue Nov 6, 2020
Bump pub

Verified

This commit was signed with the committer’s verified signature.
novemberborn Mark Wubben
New commits:

git log --format="%C(auto) %h %s" 900e796a37fd9f68de9dd183cf4798fe5f055eaa..4ca4767a6c00b2dadecdaee9a4866dae40ef25f2
 4ca4767a Added a dart pub outdated --transitive option (#2731)
 6b145bd6 Deprecate --server argument to `pub publish` and `pub uploader`. (#2697)
 7737023a don't warn if previous prerelease was null safe (#2730)
 62f92838 Improve outdated --mode=null-safety (#2724)
 cc589ec3 Change message for no Latest resolution (#2729)
 656803e9 Require sdk constraint (#2718)
 8309d877 Added test that dev_dependency does not trigger null-safety warnings when publishing (#2727)
 332ea049 Remove warning about mixed mode. (#2723)
 a98a1f23 Simplify null-safety analysis in `pub outdated --mode=null-safety` (#2721)
 5fba2015 Outdated null safety implies prereleases (#2722)
 fb9ec4af Fixed bug in yaml_edit (#2703)

Change-Id: I22a084aee06542e04a272269fb0134f0ac62f779
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170690
Commit-Queue: Sigurd Meldgaard <[email protected]>
Reviewed-by: Michael Thomsen <[email protected]>
Reviewed-by: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants