Skip to content

dev_compiler: Allow read-only access to initializing formals by default #27894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eernstg opened this issue Nov 24, 2016 · 5 comments
Closed
Assignees

Comments

@eernstg
Copy link
Member

eernstg commented Nov 24, 2016

This is the dev_compiler specific issue for #27891; please refer to that issue for additional information.

@jmesserly
Copy link

fyi, I don't think we'll have to do anything once analyzer fixes #27895, other than make sure we have a test case.

@eernstg
Copy link
Member Author

eernstg commented Nov 29, 2016

Test cases: Please check out tests/language/initializing_formal_*_test.dart and tests/language/parameter_initializer5_test.dart (the former ones are test cases for this feature; the latter one used to test that the access was a compile-time error, and it has been adjusted now that it isn't an error any more).

@jmesserly
Copy link

@vsmenon I think you had a CL for this?

@vsmenon
Copy link
Member

vsmenon commented Nov 29, 2016

I had a CL to flip the flag, but it's obsoleted by Brian's flipping it on by default. I had checked the tests - they pass. Now that it's on, we should migrate them over:

https://codereview.chromium.org/2534293002/

@vsmenon
Copy link
Member

vsmenon commented Nov 29, 2016

Closing, as it's on by default. I'll land the tests on review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants