Skip to content

Bots are not analyzing code in strong mode. #28013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stereotype441 opened this issue Dec 6, 2016 · 1 comment
Closed

Bots are not analyzing code in strong mode. #28013

stereotype441 opened this issue Dec 6, 2016 · 1 comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@stereotype441
Copy link
Member

test.py currently runs all analyzer tests from the root directory of the SDK repo. Analyzer CLI looks for the .analysis_options file in the directory analyzer was run from (not in the directory of the file being analyzed). Since there is no .analysis_options file at the root of the SDK repo, this means that all analyzer tests run by the analyzer bot are run in spec mode, even when analyzing a package whose .analysis_options file indicates that it should be analyzed in strong mode.

Note: a clumsy workaround is to put the string // SharedOptions=--strong at the top of the test file. This is not a great workaround, though, since we would have to remember to do it every time a test file is added.

@stereotype441 stereotype441 added legacy-area-analyzer Use area-devexp instead. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Dec 6, 2016
@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Dec 7, 2016
@devoncarew
Copy link
Member

I believe they are now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants