Skip to content

VM: remove flag for new assert with message feature #28136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mit-mit opened this issue Dec 16, 2016 · 2 comments
Closed

VM: remove flag for new assert with message feature #28136

mit-mit opened this issue Dec 16, 2016 · 2 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Milestone

Comments

@mit-mit
Copy link
Member

mit-mit commented Dec 16, 2016

The new assert with message feature -- sdk #24213 -- is now complete everywhere, and should not be behind a flag. Please remove that flag.

Also, confirmed it's working great:

test.dart:

main() {
  assert(2 > 1, 'Math is broken');
  var v;
  assert(v != null, 'v is null');
}

result:

$ ./bin/dart -c --assert-message test.dart

Unhandled exception:
'file:///Users/mit/tmp/dart-sdk/test.dart': Failed assertion: line 4 pos 10: 'v != null': v is null
#0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:33)
#1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:29)
#2      main (file:///Users/mit/tmp/dart-sdk/test.dart:4:10)
#3      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:261)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
mit-macbookpro2:dart-sdk mit$```
@mit-mit mit-mit added this to the 1.22 milestone Dec 16, 2016
@mit-mit
Copy link
Member Author

mit-mit commented Dec 16, 2016

@mit-mit mit-mit added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Dec 16, 2016
@mit-mit
Copy link
Member Author

mit-mit commented Dec 16, 2016

CC @a-siva

@a-siva a-siva self-assigned this Dec 19, 2016
@mhausner mhausner assigned mhausner and unassigned a-siva Dec 19, 2016
mhausner added a commit that referenced this issue Dec 19, 2016
Enable support for messages in assert statements. Remove the
VM flag.

BUG=#28136

Review-Url: https://codereview.chromium.org/2586363003 .
@a-siva a-siva closed this as completed Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants