Skip to content

fix strong mode errors in dart:math min, max #28909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmesserly opened this issue Feb 27, 2017 · 2 comments
Closed

fix strong mode errors in dart:math min, max #28909

jmesserly opened this issue Feb 27, 2017 · 2 comments
Assignees
@munificent
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). P2 A bug or feature request we're likely to work on

Comments

@jmesserly
Copy link

@munificent 's CL here: https://codereview.chromium.org/2386493003 will need to be re-landed in the SDK once we unfork. Opening this as a tracking bug.
@jmesserly
Copy link
Author

the idea is to make min/max external and implement using a patch version in DDC.

@jmesserly jmesserly added area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). Type: SDK libraries strong P2 A bug or feature request we're likely to work on labels Feb 27, 2017
@jmesserly jmesserly mentioned this issue May 3, 2017
Closed
@munificent munificent self-assigned this May 3, 2017
@munificent
Copy link
Member

Fixed in: https://codereview.chromium.org/2858353003/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@munificent @jmesserly