dart2js: In checked mode, `void` should allow any value. #28937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

floitschG opened this issue Mar 1, 2017 · 2 comments

Assignees

Labels

Milestone

Contributor

floitschG commented Mar 1, 2017

This is the dart2js issue for #28935.

floitschG added the web-dart2js label

floitschG self-assigned this

floitschG mentioned this issue

In checked mode, void should allow any value. #28935

Closed

3 tasks

floitschG added this to the 1.23 milestone

mit-mit modified the milestones: 1.24, 1.23

Member

mit-mit commented Mar 15, 2017

Punting to 1.24 per dart-leads discussion.

floitschG closed this as completed in

521dc66

floitschG added a commit that referenced this issue


          Void is not required to be null anymore.

4e52c45

In checked mode, `void` now accepts any value.

Fixes #28937.
Fixes #28938.

BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
[email protected], [email protected], [email protected]

Committed: 521dc66
Reverted: a3c0cb6
Review-Url: https://codereview.chromium.org/2718513002 .

Contributor Author

floitschG commented May 3, 2017

Had to revert.

floitschG reopened this

floitschG closed this as completed in

6caf9ef

floitschG added a commit that referenced this issue


          Void is not required to be null anymore.

8e01f69

In checked mode, `void` now accepts any value.

Fixes #28937.
Fixes #28938.

BUG= http://dartbug.com/28937
BUG= http://dartbug.com/28938
[email protected], [email protected], [email protected], [email protected]

Committed: 521dc66
Reverted: a3c0cb6
Committed: 4e52c45
Reverted: 4b35d39
Committed: 6caf9ef
Reverted: 30d9bf2
Review-Url: https://codereview.chromium.org/2718513002 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment