Skip to content

Dom event handlers registration is broken. #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue May 12, 2012 · 1 comment
Closed

Dom event handlers registration is broken. #3027

DartBot opened this issue May 12, 2012 · 1 comment
Labels
closed-duplicate Closed in favor of an existing report

Comments

@DartBot
Copy link

DartBot commented May 12, 2012

This issue was originally filed by [email protected]

This issue has the same roots as http://code.google.com/p/dart/issues/detail?id=2937&q=event&colspec=ID%20Type%20Status%20Priority%20Area%20Milestone%20Owner%20Summary

It's easy to reproduce it.
We have html page:
<html>
<style type="text/css">
@-webkit-keyframes rotate {
  from {
    -webkit-transform: rotate(0deg);
  }
  to {
    -webkit-transform: rotate(360deg);
  }
}
</style>
<body>
<input type="text" id="button" value="button" />
</body>
</html>

And dart code:

import('dart:html')

void main() {
 Element elem = document.query('button');
 elem.$dom_addEventListener('webkitAnimationEnd', ([event]){ print('hack'); });
 elem.on['webkitAnimationEnd'].add(([event]){ print('suggested way'); });
 elem.style.cssText = '-webkit-animation: rotate 2s;';
}

The problem here is that the only 'hack' will be printed... 'on'-styled event binding is working only for a few simple events like 'click', 'focus', etc., but it's not enough...
@DartBot
Copy link
Author

DartBot commented May 12, 2012

This comment was originally written by [email protected]

Added Duplicate label.
Marked as being merged into #2937.

@DartBot DartBot added Type-Defect closed-duplicate Closed in favor of an existing report labels May 12, 2012
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
dart-bot pushed a commit that referenced this issue Jul 9, 2021
@jonasfj
Bump pub.
1b3b8f8 
New commits include:
```
git log --format="%C(auto) %h %s"
3c14d86a67db7207bbc9f654ac49ee60e08e5240..d159e5b9f04a7e4826b6afea7b3364d48aa0dad8
 d159e5b9 Validate and normalize hosted url. (#3030)
 12411d60 fail CI on info level issues; fix directives sorting (#3036)
 ab41ef0a Downgraded does_not_include_dot_file.dart to 2.10 (#3027)
```

Change-Id: I58e11393c5d6099406d3ba1884f69768395c7a0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206364
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: William Hesse <[email protected]>
Auto-Submit: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DartBot