Skip to content

Avoid factories if there is only one constructor. #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
floitschG opened this issue May 14, 2012 · 10 comments
Closed

Avoid factories if there is only one constructor. #3045

floitschG opened this issue May 14, 2012 · 10 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@floitschG
Copy link
Contributor

We currently create factories even if there is only one constructor in a class. We should see this and merge the factory and JS-constructor.
@kasperl
Copy link

kasperl commented Sep 3, 2012

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed Priority-Medium label.
Added Priority-Low label.

@peter-ahe-google
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the Later milestone.
Removed Priority-Low label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@DartBot
Copy link

DartBot commented May 28, 2013

This comment was originally written by [email protected]

If the constructor is not inlineable, we currently still generate both. I guess that was the original observation Florian, right? I don't understand the "even if there is only one constructor": we do generate one factory per constructor.

Removed Type-Defect label.
Added Type-Enhancement label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
dart-bot pushed a commit that referenced this issue Jul 19, 2021
@jonasfj
Bump pub.
6e64006 
New commits include:
```
git log --format="%C(auto) %h %s" d159e5b9f04a7e4826b6afea7b3364d48aa0dad8..70b1a4f9229a36bac6340ec7eae2b2068baac96c
 70b1a4f9 Detect Flutter SDK location relative to Dart SDK (#3045)
 b4be5c57 Dart format with latest SDK (#3044)
 2a08832e Fix dart_tools typos (#3042)
```

Change-Id: I5d27c9545f5e13a55cf1719fe1408a88fba88c8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207304
Auto-Submit: Jonas Jensen <[email protected]>
Commit-Queue: William Hesse <[email protected]>
Reviewed-by: William Hesse <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 23, 2022
Roll Dart Documentation Generator from cf0685a2d1ce to c58f21042ebd (…
d18798a 
…2 revisions)

https://dart.googlesource.com/dartdoc/+log/cf0685a2d1ce..c58f21042ebd

2022-05-21 [email protected] Fix two issues with constructors (#3044)
2022-05-21 [email protected] inline the used charcode constants (#3045)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: Ic1521181d7c2784b52018d7233ac0a937d0e979c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245640
Reviewed-by: Nate Bosch <[email protected]>
Commit-Queue: Nate Bosch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @matanlurey @kasperl @peter-ahe-google @floitschG @DartBot