Wrong name for invalid factory constructor

[scheglov]

class A {
  factory B() => null;
}

library;
import self as self;
import "dart:core" as core;

class A extends core::Object {
  static factory B() → self::A
    return null;
}

Looking inside of the generated Kernel Procedure, I see that the name of the factory is set to B, which is incorrect, because if it were A, then the name would have been empty.

What I would expect is that an error is reported, and factory B() is parsed as factory A(), and correspondingly factory B.named() as factory A.named().

[peter-ahe-google]

I agree. This isn't ideal. I noticed this when working on e7f26dc.

[jensjoha]

Current behavior for

class A {
  factory B() => null;
  factory B.named() => null;
}

when compiling with pkg/front_end/tool/fasta compile tmp.dart --dump-ir --strong:

Note: strong mode support is preliminary and may not work.
tmp.dart:3:11: Error: 'B.named' isn't a legal method name.
Did you mean 'A.named'?
  factory B.named() => null;
          ^
tmp.dart: Error: Couldn't find constructor 'B'.
tmp.dart: Error: Couldn't find constructor 'B.named'.
library;
import self as self;
import "dart:core" as core;

class A extends core::Object {
  static factory B() → self::A
    return null;
  static factory named() → self::A
    return null;
}
static const field dynamic #errors = const <dynamic>["tmp.dart:3:11: Error: 'B.named' isn't a legal method name.\nDid you mean 'A.named'?\n  factory B.named() => null;\n          ^", "tmp.dart: Error: Couldn't find constructor 'B'.", "tmp.dart: Error: Couldn't find constructor 'B.named'."]/* from null */;

So an error is given and B.named() does seem to be parsed as A.named().