Implicit method closures aren't canonicalized

[DartBot]

This issue was originally filed by @bp74

---

What steps will reproduce the problem?

1. Here is a sample which shows the problem:

class Test1 {
  Test1() {
    document.body.on.click.add(_onBodyClick);
  }
  _onBodyClick(event) {
    print("Test1: onBodyClick");
    document.body.on.click.remove(_onBodyClick);
  }
}

class Test2 {
  EventListener _eventListener;
  Test2() {
    _eventListener = _onBodyClick;
    document.body.on.click.add(_eventListener);
  }
  _onBodyClick(event) {
    print("Test2: onBodyClick");
    document.body.on.click.remove(_eventListener);
  }
}

void main() {
  Test1 test1 = new Test1();
  Test2 test2 = new Test2();
}

What is the expected output? What do you see instead?

Both classes add an EventListener to the click event of the body, but only the "Test2" class can remove the EventListener again. The funny thing is that it is the same in the Dart-VM and in all browsers when compilied to JavaSscript. It almost looks like "works as desingend" but if this is by purpose i think it should be changed.

What version of the product are you using? On what operating system?
Dart Build 7696 32 bit, Windows 7 64 bit

[DartBot]

This comment was originally written by [email protected]

---

Pavel, maybe you check if it's related to your recent change and reassign if not?

---

Set owner to [email protected].
Added Area-Dartium, Triaged labels.

[DartBot]

This comment was originally written by [email protected]

---

The problem here is that implicit method closures aren't canonicalized.

Here is a reduced case:

class A {
  foo() {
    print(bar == bar);
  }
  bar() {}
}

main() {
  new A().foo();
}

which prints false.

Gilad, are there any plans to fix it?

---

cc @gbracha.
Removed the owner.
Removed Area-Dartium label.
Added Area-Language label.
Changed the title to: "Implicit method closures aren't canonicalized".

[gbracha]

We plan to look into this issue pretty soon. And BTW, the bug is a
duplicate,

[gbracha]

Set owner to @gbracha.
Added Duplicate label.
Marked as being merged into #144.