Skip to content

--preview-dart-2 should turn on --strong, --reify_generic_functions, --limit_ints_to_64_bits so that we get true dart 2.0 semantics and performance #31485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-siva opened this issue Nov 29, 2017 · 3 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution

Comments

@a-siva
Copy link
Contributor

a-siva commented Nov 29, 2017

The --preview-dart-2 option in 'flutter engine' and 'command line dart' should turn on
--strong
--reify_generic_functions
--limit_ints_to_64_bits
So that we get the true 2.0 semantics and performance.

@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Nov 29, 2017
@a-siva a-siva added this to the 2.0-alpha milestone Nov 29, 2017
@mraleph mraleph added the P0 A serious issue requiring immediate resolution label Nov 30, 2017
@a-siva
Copy link
Contributor Author

a-siva commented Dec 4, 2017

This also requires updating the version of Dart in flutter/flutter to a newer SDK (2.0 version).
Currently doing that produces a number of errors, there is a pull request out to fix some of these errors flutter/flutter#13223

@a-siva a-siva self-assigned this Jan 1, 2018
@a-siva
Copy link
Contributor Author

a-siva commented Jan 3, 2018

Two pull requests are currently out for review to address this -
flutter/engine#4504
flutter/flutter#13859

Landing these two will enable the ability to run flutter apps in strong mode.
There are still errors which need to be fixed in the flutter code to make it strong mode clean.

@a-siva
Copy link
Contributor Author

a-siva commented Jan 5, 2018

The two PRs have landed and it is now possible to run flutter code in strong mode using flutter tools

flutter build flx --preview-dart-2 --strong
flutter run --preview-dart-2 --strong
flutter build aot --preview-dart-2 --strong

Flutter applications still fail when run in strong mode because of other issues, we now have a meta
issue at #31789 to track all other blocker issues that are stopping flutter from running in strong mode.

@a-siva a-siva closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution
Projects
None yet
Development

No branches or pull requests

2 participants