This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for --strong option in the engine, create a strong mode version of the platform file #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-siva
commented
Jan 3, 2018
a-siva
commented
- Add a --strong option to the front end server so we can compile dart files in strong mode
- Plumb the --strong option through the dart controller into the VM
- Create a strong mode version of platform.dill so it can be used when running in strong mode
…de with preview-dart-2.
- Fix a strong mode static error in the assert statement
aam
approved these changes
Jan 3, 2018
aam
reviewed
Jan 3, 2018
| ] | ||
|
|
||
| outputs = [ | ||
| "$root_out_dir/flutter_patched_sdk/platform_strong.dill", |
There was a problem hiding this comment.
You probably want to use this file in frontend server when running in strong mode (server.dart:173)
There was a problem hiding this comment.
Fixed code to link with the correct platform dill file during aot builds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.