When changing from "#source" to "#import" the error-message in the imported file does not go away.

[stevemessick]

floitsch: When changing from "#source" to "#import" the error-message in the imported file does not go away.

Say I have file A.dart and B.dart. Both are libraries with a "#library" line on top.
If A.dart #sources B.dart I get the error message "A source which was included by another source via a #source directive cannot itself contain directives: B.dart"
The error points to the #library directive inside B.dart.
This, by itself, is already annoying, since it doesn't tell me which other file actually did the #source, but that's not the bug.

Now if I go to A.dart and change the #source to an #import, the error should go away, but currently that does not happen. I have to 'force reanalyze' to remove the error-line.

[danrubel]

Set owner to @scheglov.

[scheglov]

Isn't this Analysis Server problem?

I've added tweak for error message.
https://chromiumcodereview.appspot.com/10448054

---

cc @danrubel.
Added Started label.

[danrubel]

If you find that it is, feel free to reassign.

[scheglov]

Such dangling/stale errors are by default Analysis Server problem.
Just because "force Re-Analyse" solves this.

Test.dart
//#import('LibB.dart', prefix: 'aaa');
#source('LibB.dart');

LibB.dart
#library("B");

When I compile this, I see AnalysisMarkerManager.parsed(AnalysisEvent) called with Test.dart and LibB.dart and then AnalysisMarkerManager.resolved(AnalysisEvent) with both. Error added to the LibB.dart

However when I then change Test.dart to
#import('LibB.dart', prefix: 'aaa');
//#source('LibB.dart');

I see that only Test.dart is parsed and resolved.
Not sure exactly why, I can just guess that because LibB.dart is not changed, so it was not parsed.

---

Set owner to @danrubel.

[danrubel]

Added this to the M1 milestone.

[danrubel]

https://chromiumcodereview.appspot.com/10837119/

[danrubel]

Added Fixed label.