Skip to content

Please test --package-root #3170

Closed
Closed
@peter-ahe-google

Description

@peter-ahe-google

We need a test of the --package-root command line.

Activity

peter-ahe-google

peter-ahe-google commented on Jun 13, 2012

@peter-ahe-google
ContributorAuthor

This should include testing stuff like issue #3147.

peter-ahe-google

peter-ahe-google commented on Aug 24, 2012

@peter-ahe-google
ContributorAuthor

Added this to the M2 milestone.
Marked this as being blocked by #3168.
Unmarked this as being blocked by #3168.

whesse

whesse commented on Aug 24, 2012

@whesse
Contributor

Can you use --special-command for this?

peter-ahe-google

peter-ahe-google commented on Aug 24, 2012

@peter-ahe-google
ContributorAuthor

I don't think so. I need to write a few tests with different --package-root arguments, not run the test suite N times with different command-line arguments.

DartBot

DartBot commented on Oct 2, 2012

@DartBot

This comment was originally written by adamle...@gmail.com


One test case from me:
dart --enable-checked-mode --package-root=C:\dart-sdk\pkg\ lib\Adder.dart
fails

but
dart --enable-checked-mode --package-root=CC:\dart-sdk\pkg\ lib\Adder.dart
works fine

Windows7, Dart 13122

For the sake of completeness, Adder.dart:

#library('mylib');
#import('package:unittest/unittest.dart');
class Adder {
  int add(int a, int b) {
    return a+b;
  }
}

void main() {
  test('aaa', (){
    var adder = new Adder();
    expect(adder.add(2,4), equals(6));
  });
}

peter-ahe-google

peter-ahe-google commented on Dec 10, 2012

@peter-ahe-google
ContributorAuthor

Removed this from the M2 milestone.
Added this to the M3 milestone.

peter-ahe-google

peter-ahe-google commented on Feb 19, 2013

@peter-ahe-google
ContributorAuthor

Removed this from the M3 milestone.
Added this to the M4 milestone.

larsbak

larsbak commented on May 28, 2013

@larsbak

Removed this from the M4 milestone.
Added this to the M5 milestone.

kasperl

kasperl commented on Jun 4, 2014

@kasperl

Removed this from the M5 milestone.
Added this to the 1.6 milestone.

kasperl

kasperl commented on Jul 10, 2014

@kasperl

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

kasperl

kasperl commented on Aug 4, 2014

@kasperl
added
P2A bug or feature request we're likely to work on
type-bugIncorrect behavior (everything from a crash to more subtle misbehavior)
and removed on Feb 29, 2016
matanlurey

matanlurey commented on Jun 22, 2018

@matanlurey
Contributor

I imagine the CFE is sufficient here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P2A bug or feature request we're likely to work onarea-testCross-cutting test issues (use area- labels for specific failures; not used for package:test).closed-obsoleteClosed as the reported issue is no longer relevanttype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @kevmoo@matanlurey@kasperl@whesse@peter-ahe-google

      Issue actions

        Please test --package-root · Issue #3170 · dart-lang/sdk