Skip to content

[VM] Possibly incorrect error message when explicitly using this in a constructor initializer #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue May 23, 2012 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@DartBot
Copy link

DartBot commented May 23, 2012

This issue was originally filed by [email protected]


Code:
class C {
  C() : v = this.f {}
  var v;
  final f = 1;
}

The compile-time error I see on VM is:

unexpected use of 'this' in primary expression
  C() : v = this.f {}
            ^
According to spec, the initializer requires a conditionalExpression argument, which can be reduced to a postfixExpression of the form primary.identifier and this.f perfectly matches this production.
When an unqualified invocation/field access is used, the error is about illegal access to 'this', and it should probably be the same error in this case.

@kasperl
Copy link

kasperl commented May 24, 2012

Added Area-VM, Triaged labels.

@DartBot
Copy link
Author

DartBot commented May 24, 2012

This comment was originally written by @mhausner


If I understand this right, the request is to have the same error message whether I write v = f or v = this.f in the initializer. That makes sense, will do.


Set owner to @mhausner.

@DartBot
Copy link
Author

DartBot commented May 24, 2012

This comment was originally written by @mhausner


Added Accepted label.

@DartBot
Copy link
Author

DartBot commented May 30, 2012

This comment was originally written by @mhausner


Error messages hopefully clarified in r8134


Added Fixed label.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels May 30, 2012
copybara-service bot pushed a commit that referenced this issue Oct 29, 2021
Changes:
```
> git log --format="%C(auto) %h %s" 78bc50c..0035a40
 https://dart.googlesource.com/pub.git/+/0035a40f Fix echo mode crash on `token add` (#3194)
 https://dart.googlesource.com/pub.git/+/a75a8c17 Don't warn against discontinued transitive dependencies (#3195)
 https://dart.googlesource.com/pub.git/+/cf2ed105 Fix analytics code (#3197)
 https://dart.googlesource.com/pub.git/+/08e13f7b Remove unused golden files (#3189)
 https://dart.googlesource.com/pub.git/+/b6293b80 Fix log message related to `pub global activate`  (#3187)
 https://dart.googlesource.com/pub.git/+/94f6b477 Introducing command-line interface tests (#3161)
 https://dart.googlesource.com/pub.git/+/3ba8134f More details from getExecutableForCommand (#3186)
 https://dart.googlesource.com/pub.git/+/a2dbcfff Shorthand syntax for hosted dependencies (#3133)
 https://dart.googlesource.com/pub.git/+/435e4e3f Shuffle analytics (#3185)

```

Diff: https://dart.googlesource.com/pub.git/+/78bc50c7833451c24e531713362e46fd50621ff0~..0035a40f25d027130c0314571da53ffafc6d973b/
Change-Id: Idfd7c382985d1ad3e3ad87a621dc79d3b74e898e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218620
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
copybara-service bot pushed a commit that referenced this issue Sep 27, 2022
…1 revision)

https://dart.googlesource.com/dartdoc/+log/c22e5e77de29..22facbb145d7

2022-09-27 [email protected] client search code: stop event propagation when navigating (#3185)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I46e43aa6b1c8448258a792bd65d5fc438690fe34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261241
Commit-Queue: Nate Bosch <[email protected]>
Commit-Queue: DEPS Autoroller <[email protected]>
Reviewed-by: Kevin Moore <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

2 participants