-
Notifications
You must be signed in to change notification settings - Fork 1.7k
dart2js: please implement "super" property read/store #3191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Removed Priority-Medium label. |
Set owner to @peter-ahe-google. |
Is this really fixed? I was under the impression that r8140 only fixed the read part. This issue seems to cover both. |
Sorry, I just looked at the example. The example is fixed. I'm still working on store. Added Started label. |
Super read is fixed in r8140. |
Super write is implemented in r8201. We still don't support overriding fields, which is why tests/language/super_field_access_test.dart fails. I'll file a separate bug for that. Added Fixed label. |
Issue #3407 has been merged into this issue. |
…3 revisions) https://dart.googlesource.com/dartdoc/+log/6b8b1c46da9a..ce5bd271eda9 2022-09-27 [email protected] Fix generic typedef pointing to typedef (#3193) 2022-09-27 [email protected] Unnamed libraries (#3189) 2022-09-27 [email protected] Make InheritingContainer._inheritedElements late final (#3191) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I371d173b9225721274f4faf652b56ee4f9fa8082 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261461 Commit-Queue: DEPS Autoroller <[email protected]> Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Devon Carew <[email protected]>
This issue was originally filed by @bp74
What steps will reproduce the problem?
class foo {
int _x = 1;
num get x() => _x;
}
class bar extends foo {
num get x() => super.x * 2;
}
void main() {
bar b = new bar();
print(b.x);
}
What is the expected output? What do you see instead?
dart2js has an error saying: "internal error: super property read not implemented"
same thing with setter: "internal error: super property store not implemented"
What version of the product are you using? On what operating system?
Dart Editor 7916 32 bit, WIndows 7 64 bit
The text was updated successfully, but these errors were encountered: