Skip to content

dart2js: please implement "super" property read/store #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue May 23, 2012 · 7 comments
Closed

dart2js: please implement "super" property read/store #3191

DartBot opened this issue May 23, 2012 · 7 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js

Comments

@DartBot
Copy link

DartBot commented May 23, 2012

This issue was originally filed by @bp74


What steps will reproduce the problem?

class foo {
  int _x = 1;
  num get x() => _x;
}

class bar extends foo {
  num get x() => super.x * 2;
}

void main() {
  bar b = new bar();
  print(b.x);
}

What is the expected output? What do you see instead?

dart2js has an error saying: "internal error: super property read not implemented"
same thing with setter: "internal error: super property store not implemented"

What version of the product are you using? On what operating system?

Dart Editor 7916 32 bit, WIndows 7 64 bit

@kasperl
Copy link

kasperl commented May 24, 2012

Removed Priority-Medium label.
Added Priority-High, Area-Dart2JS, Triaged labels.

@peter-ahe-google
Copy link
Contributor

Set owner to @peter-ahe-google.
Added Started label.

@kasperl
Copy link

kasperl commented May 31, 2012

Is this really fixed? I was under the impression that r8140 only fixed the read part. This issue seems to cover both.

@peter-ahe-google
Copy link
Contributor

Sorry, I just looked at the example. The example is fixed. I'm still working on store.


Added Started label.

@peter-ahe-google
Copy link
Contributor

Super read is fixed in r8140.

@peter-ahe-google
Copy link
Contributor

Super write is implemented in r8201.

We still don't support overriding fields, which is why tests/language/super_field_access_test.dart fails. I'll file a separate bug for that.


Added Fixed label.

@dgrove
Copy link
Contributor

dgrove commented Jun 8, 2012

Issue #3407 has been merged into this issue.

@DartBot DartBot added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Jun 8, 2012
copybara-service bot pushed a commit that referenced this issue Sep 27, 2022
…3 revisions)

https://dart.googlesource.com/dartdoc/+log/6b8b1c46da9a..ce5bd271eda9

2022-09-27 [email protected] Fix generic typedef pointing to typedef (#3193)
2022-09-27 [email protected] Unnamed libraries (#3189)
2022-09-27 [email protected] Make InheritingContainer._inheritedElements late final (#3191)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I371d173b9225721274f4faf652b56ee4f9fa8082
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261461
Commit-Queue: DEPS Autoroller <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants