Skip to content

Expand ConstExprBuilder to handle non-const expressions #32674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stereotype441 opened this issue Mar 26, 2018 · 3 comments
Closed

Expand ConstExprBuilder to handle non-const expressions #32674

stereotype441 opened this issue Mar 26, 2018 · 3 comments
Assignees
@stereotype441
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart2 Beta 3

Comments

@stereotype441
Copy link
Member

Currently, the analyzer's ConstExprBuilder class only handles constant expressions. In order to fix #32525, we'll need to expand it to handle non-constant expressions as well. In the process we should rename it to something that doesn't have "const" in the name (perhaps just "ExprBuilder").
@stereotype441 stereotype441 added P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. labels Mar 26, 2018
@stereotype441 stereotype441 self-assigned this Mar 26, 2018
@stereotype441 stereotype441 mentioned this issue Mar 26, 2018
Closed
@dgrove
Copy link
Contributor

dgrove commented Mar 26, 2018

Since this is blocking #32525, either this should be in the Dart2-Beta 3 milestone, or the other issue should be moved out of that milestone.

@stereotype441 stereotype441 added this to the Dart2 Beta 3 milestone Mar 26, 2018
@stereotype441
Copy link
Member Author

@dgrove Thanks, fixed

dart-bot pushed a commit that referenced this issue Mar 27, 2018
@stereotype441
Make _ConstExprBuilder re-usable.
7df4235 
This CL moves _ConstExprBuilder to its own file, renames it to
ExprBuilder (so that it can be re-used for non-const expressions), and
begins adding support for expression types that can appear in
non-const expressions.

It also introduces an expr_builder_test.dart file to make testing of
ExprBuilder easier.

See #32674.

Change-Id: I5a3d91408c51770ee8f70621032a2f0767eaea55
Reviewed-on: https://dart-review.googlesource.com/48462
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@stereotype441
Copy link
Member Author

Fixed in be3baa0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stereotype441 stereotype441

Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart2 Beta 3
Development

No branches or pull requests
2 participants
@stereotype441 @dgrove