-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Analyzer/CFE inconsistency on super calls to abstract methods. #33662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
legacy-area-analyzer
Use area-devexp instead.
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
Comments
32 tasks
cc @keertip |
Is this issue related to #33420? |
Agree that it's an error in Dart 2. |
Ok, moving this over to an analyzer bug. |
This was referenced Jul 24, 2018
File a spec issue to ensure the text reflects this: #33963 . |
dart-bot
pushed a commit
that referenced
this issue
Sep 11, 2018
There is no distinction between them from the langauge of view anymore. This is a preparatory step before reporting super-invoked abstract class members as errors, which we should do according to the issue. Which, in turn, is for consistency between repoting corresponding error for super-invoked, but not concrete members in mixin applications. [email protected] Bug: #33662 Change-Id: I00e8f185dbbdd1ffac88c500394a1e1497be6f9a Reviewed-on: https://dart-review.googlesource.com/74481 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Sep 12, 2018
[email protected] Bug: #33662 Change-Id: Ic80386c20acd2cd1ceebeb90fbb1d6e18982b024 Reviewed-on: https://dart-review.googlesource.com/74499 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
legacy-area-analyzer
Use area-devexp instead.
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
Consider this code:
When run with the CFE, this produces the following:
When run through the analyzer, it produces the following:
I believe that this should be an error on all platforms.
cc @lrhn do you agree that this is an error or am I missing something?
cc @kmillikin, @bwilkerson
The text was updated successfully, but these errors were encountered: