Skip to content

Add optional List<int> param to Hash.digest for easier one-liner #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sethladd opened this issue Jun 5, 2012 · 4 comments
Closed

Add optional List<int> param to Hash.digest for easier one-liner #3396

sethladd opened this issue Jun 5, 2012 · 4 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

sethladd commented Jun 5, 2012

Suggesting adding an optional List<int> param to Hash.digest() for the more simple one-liner cases.

Instead of:

var digest = sha256.update("message".charCodes()).digest();

It would be nicer to have:

var digest = sha256.digest("message".charCodes());

Thanks!

@kevmoo
Copy link
Member

kevmoo commented Feb 17, 2014

Removed Library-Crypto label.
Added Pkg-Crypto label.

@kevmoo
Copy link
Member

kevmoo commented Feb 17, 2014

You mention 'digest' and 'update' on sha256.

I think you're referring to an old version of the API>


Added AssumedStale label.

@kevmoo
Copy link
Member

kevmoo commented Feb 17, 2014

Removed Area-Library label.
Added Area-Pkg label.

@sethladd sethladd added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant labels Feb 17, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/core#178.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue May 4, 2022
Changes:
```
> git log --format="%C(auto) %h %s" a949b32..6068f47
 https://dart.googlesource.com/pub.git/+/6068f47c Fixing link example "User-Agent" (#3400)
 https://dart.googlesource.com/pub.git/+/cd0d6992 Make tests more agnostic to the test environment (#3402)
 https://dart.googlesource.com/pub.git/+/1f8db828 Fix retrieval of name in `pub global activate -sgit` (#3407)
 https://dart.googlesource.com/pub.git/+/ed63f212 Limit the number of concurrent precompilations (#3396)
 https://dart.googlesource.com/pub.git/+/d82f80a5 Fix crash when checking code with bad import (#3392)
 https://dart.googlesource.com/pub.git/+/b9ae624e Relative urls in lockfile for git urls (#3385)
 https://dart.googlesource.com/pub.git/+/62bb2440 Fix `dependency_services apply` for packages with relative imports (#3374)

```

Diff: https://dart.googlesource.com/pub.git/+/a949b329b1b51f5f3973a790e0a0a45897d837de~..6068f47c264ef790e16411b31b2c94ad6beb1ab6/
Change-Id: Ib18c2647e27a34d84005214b844351f314698611
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243321
Commit-Queue: Sigurd Meldgaard <[email protected]>
Reviewed-by: Sarah Zakarias <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants