Skip to content

two DDC test failures related to moving the analyzer to --use-fasta-parser #34041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devoncarew opened this issue Jul 31, 2018 · 5 comments
Closed

two DDC test failures related to moving the analyzer to --use-fasta-parser #34041

devoncarew opened this issue Jul 31, 2018 · 5 comments
Labels
web-dev-compiler

Comments

@devoncarew
Copy link
Member 

tests/corelib_2/corelib_2.status
  format_exception_test: RuntimeError
tests/language_2/language_2_dartdevc.status
  super_conditional_operator_test/01: Crash
@devoncarew
Copy link
Member Author

Related to https://dart-review.googlesource.com/c/sdk/+/67090/4.

@bwilkerson
Copy link
Member

@danrubel

@devoncarew
Copy link
Member Author

And, cc'ing @vsmenon as well (note, the above CL has not yet landed).

@vsmenon
Copy link
Member

vsmenon commented Jul 31, 2018

Here's a link to the log:

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8939457313331647536/+/steps/ddc_tests/0/stdout

The first appears to be an issue with new lines.

The second is crashing in the analyzer:

AnalysisException: Cannot compute SOURCE_KIND for /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_tests/language_2/super_conditional_operator_test_01.dart
Caused by Unexpected exception while performing ParseDartTask for source /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_tests/language_2/super_conditional_operator_test_01.dart
#0      AnalysisTask._safelyPerform (package:analyzer/src/task/api/model.dart:335:7)
#1      AnalysisTask.perform (package:analyzer/src/task/api/model.dart:222:7)
#2      AnalysisDriver.performWorkItem (package:analyzer/src/task/driver.dart:285:10)
#3      AnalysisDriver.computeResult (package:analyzer/src/task/driver.dart:110:22)
#4      AnalysisContextImpl.computeResult (package:analyzer/src/context/context.dart:717:14)
#5      AnalysisContextImpl.computeKindOf (package:analyzer/src/context/context.dart:675:14)
#6      ModuleCompiler.compile (package:dev_compiler/src/analyzer/module_compiler.dart:162:19)

dart-bot pushed a commit that referenced this issue Sep 6, 2018
Improve super initializer recovery
dc0aae5 
This CL addresses one of the issues in #34041
by fixing an AstBuilder crash and improving recovery of super constructor calls
in a constructor initializer list.

In addition, this adds a TestDescriptor adjustValidUnitBeforeComparison field
to support the new recovery tests.

Change-Id: I9e687aed34ea293700bd45d7c13ce36e83a00a05
Reviewed-on: https://dart-review.googlesource.com/73286
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Dan Rubel <[email protected]>
@devoncarew devoncarew mentioned this issue Sep 6, 2018
Closed
5 tasks
@natebosch
Copy link
Member

Analyzer isn't moving in this direction anymore, and DDC is moving to CFE. We haven't deleted the old code path yet but this particular issue isn't something we need to have solved before we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@devoncarew @vsmenon @bwilkerson @natebosch