Skip to content

Add a quick fix for unawaited futures in an async context #34431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matanlurey opened this issue Sep 11, 2018 · 2 comments
Closed

Add a quick fix for unawaited futures in an async context #34431

matanlurey opened this issue Sep 11, 2018 · 2 comments
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) customer-google3 devexp-quick-fix Issues with analysis server (quick) fixes legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@matanlurey
Copy link
Contributor

... i.e. a fix for unawaited_futures.

I'd suggest the following 2 quick fixes to be available:

  1. (Preferred) Insert await
  2. (Optional) Import package:pendatic (if required), and wrap in unawaited(<expression>).

/cc @davidmorgan @bwilkerson @srawlins

@matanlurey matanlurey added legacy-area-analyzer Use area-devexp instead. devexp-quick-fix Issues with analysis server (quick) fixes type-enhancement A request for a change that isn't a bug customer-google3 labels Sep 11, 2018
@srawlins srawlins added the P3 A lower priority bug or feature request label Nov 10, 2020
@om-ha
Copy link

om-ha commented Oct 18, 2021

I think the importance of this the linter rule unawaited_futures is already known by everyone.

Having this quick-fix implemented, augments the usefulness of this linter rule. expression -> unawaited(expression)

For reference, please check original the issue I originally (and incorrectly) posted in Dart-Code #3623

@srawlins srawlins added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label May 20, 2022
@asashour
Copy link
Contributor

This can be closed, both fixes are now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) customer-google3 devexp-quick-fix Issues with analysis server (quick) fixes legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants