Skip to content

Add a fix to wrap with unawaited for unawaited and discarded Futures #49262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue Jun 14, 2022 · 0 comments
Closed

Add a fix to wrap with unawaited for unawaited and discarded Futures #49262

pq opened this issue Jun 14, 2022 · 0 comments
Assignees
@pq
Labels
devexp-quick-fix Issues with analysis server (quick) fixes legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Jun 14, 2022

The discarded_futures and unawaited_futures diagnostics could have a quick fix that wraps the discarded/unawaited future in a call to unawaited().

See also #58747 and #34431.
@pq pq added legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request devexp-quick-fix Issues with analysis server (quick) fixes type-enhancement A request for a change that isn't a bug labels Jun 14, 2022
@pq pq self-assigned this Jun 14, 2022
copybara-service bot pushed a commit that referenced this issue Jun 14, 2022
@pq
add quick-fix for discarded_futures
08d6d8f 
See: https://github.com/dart-lang/linter/issues/2923

Also: #49262

Change-Id: I57336d792b91b5bfaf8bcf4e28d8d592716b3999
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248444
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-quick-fix Issues with analysis server (quick) fixes legacy-area-analyzer Use area-devexp instead. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq