Skip to content

dart:ffi Windows 64 bit #35771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcharkes opened this issue Jan 25, 2019 · 0 comments
Closed

dart:ffi Windows 64 bit #35771

dcharkes opened this issue Jan 25, 2019 · 0 comments
Assignees
@dcharkes
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.

Comments

@dcharkes
Copy link
Contributor

Support dart:ffi on Windows.
@dcharkes dcharkes added this to the Dart VM FFI 1.0 milestone Jan 25, 2019
@kevmoo kevmoo added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Jan 25, 2019
@dcharkes dcharkes changed the title dart:ffi Windows dart:ffi Windows 64 bit Mar 6, 2019
@dcharkes dcharkes self-assigned this Mar 7, 2019
@mit-mit mit-mit removed this from the Dart VM FFI 1.0 milestone Mar 11, 2019
dart-bot pushed a commit that referenced this issue Mar 12, 2019
@mraleph
Revert "[vm/ffi] Support Windows 64 bit"
23eb57c 
This reverts commit 7f812de.

Reason for revert: Flutter build is broken on Golem.

Original change's description:
> [vm/ffi] Support Windows 64 bit
> 
> Enables dart:ffi on Windows 64 bit.
> 
> Note that function_stress_test.dart fails in two different ways, these are known bugs. #36138
> 
> Closes: #35771
> Change-Id: I73012123f2bd90b737fdc1c87c9a9630c20d5660
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95647
> Commit-Queue: Daco Harkes <[email protected]>
> Reviewed-by: Samir Jindel <[email protected]>
> Reviewed-by: Martin Kustermann <[email protected]>

[email protected],[email protected],[email protected]

Change-Id: I5be4538e3c99632a852e4dfb856248eb437fb3ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96683
Reviewed-by: Vyacheslav Egorov <[email protected]>
Commit-Queue: Vyacheslav Egorov <[email protected]>
dart-bot pushed a commit that referenced this issue Mar 13, 2019
@dcharkes
Reland "[vm/ffi] Support Windows 64 bit"
a43c525 
Enables dart:ffi on Windows 64 bit.

Note that function_stress_test.dart fails in two different ways, these are known bugs. #36138

Relanding: Fixed compilation on Android.

Closes: #35771
Change-Id: I7d0c8b64ca8c1726b7d264d4fd9213299a9f7df6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96781
Reviewed-by: Martin Kustermann <[email protected]>
Commit-Queue: Daco Harkes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @dcharkes @mit-mit