Skip to content

dart2js should support new getter/setter syntax #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gbracha opened this issue Jun 13, 2012 · 7 comments
Closed

dart2js should support new getter/setter syntax #3609

gbracha opened this issue Jun 13, 2012 · 7 comments
Assignees
Milestone

Comments

@gbracha
Copy link
Contributor

gbracha commented Jun 13, 2012

See issue #3602

@peter-ahe-google
Copy link
Contributor

Set owner to @peter-ahe-google.
Added Accepted label.

@peter-ahe-google
Copy link
Contributor

Added Started label.

@peter-ahe-google
Copy link
Contributor

Fixed in r10956.


Added Fixed label.

@DartBot
Copy link

DartBot commented Aug 23, 2012

This comment was originally written by @simonpai


I experienced the same issue with 11194. Can you help me verify it? Thanks.

@peter-ahe-google
Copy link
Contributor

Hi simon.pai,

Could you provide some additional details?

What did you do? (please include a code sample)

What happened?

What did you expect?

What did you use? (the Editor, the VM, dart2js, etc)

Cheers,
Peter

@DartBot
Copy link

DartBot commented Aug 27, 2012

This comment was originally written by @simonpai


Peter,

Sorry for late response.

  1. The issue is gone in 11367.
  2. In 11194, we had some getters like the following:

class AAA {
  Element get myElement; // this works in VM but fails to compile in dart2js
  int get myInt; // this works in both
}

I think it has been fixed in the latest version, and I'm not 100% certain about the conditions that trigger the issue as I have switched my IDE to the latest. But thanks for you effort. Let me know if you need more information about it.

Simon

@peter-ahe-google
Copy link
Contributor

Thank you, Simon.

This makes sense, because in r11293, I addressed the issue of abstract getters (implicit or explicit). Both getters in your example class, AAA, are implicitly abstract, and dart2js couldn't handle this when I closed this bug.

Cheers,
Peter

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants