Skip to content

Add analyzer support for the new packages file #38554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stereotype441 opened this issue Sep 24, 2019 · 2 comments
Closed

Add analyzer support for the new packages file #38554

stereotype441 opened this issue Sep 24, 2019 · 2 comments
Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release

Comments

@stereotype441
Copy link
Member

In response to dart-lang/language#365, the language team is considering replacing the .packages file with a new file (exact name and format TBD) that is likely to be more extensible in practice. (The old .packages file was designed to be extensible, however because of the custom nature of the format, a lot of tools that read the file format did not implement the necessary extensibility. To avoid this sort of problem happening again, we will likely switch to a more standard extensible format such as JSON).

Once the new format is decided upon, this issue will track the necessary analyzer work to implement it.
@stereotype441 stereotype441 added legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release labels Sep 24, 2019
@stereotype441
Copy link
Member Author

Currently working, with the possible exception of one corner case: the spec says that when you specify a path to a .packages file, you should first check whether there is a new packages.json file, and if so, ignore it.

@stereotype441
Copy link
Member Author

Duplicate of #39762

@stereotype441 stereotype441 marked this as a duplicate of #39762 Jan 21, 2020
dart-bot pushed a commit that referenced this issue Jan 21, 2020
@scheglov
Parse --packages file as package_config.json or .packages, depending …
1c56176 
…on the content.

Bug: #38554
Bug: #39762
Change-Id: Ibce0cabd75ecbfd3aa4e573418c2127ff7f9687e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132744
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stereotype441