Chained conditions off by a line in DDC sourcemaps

[Markzipan]

Repro:

var notNullBool = false;
var nullBool;
var otherBool = true;

void main() {
  bool calculate() => 
    otherBool && 
    notNullBool || 
    nullBool;

  print(calculate());
}

Points at the line containing notNullBool instead of nullBool.

See: b/152990150

[sigmundch]

Doesn't technically the error comes from the || operator though? If so, the current location doesn't feel unreasonable to me (and we could verify that if the "||" was on the next line, would we report the error there instead)

[Markzipan]

Probably not unreasonable from a predictability standpoint, but, given that users don't often have control over the '||' operator, it makes more sense from a debugging perspective to direct them to the code part they can change (i.e., the condition itself).

I haven't verified that though!