Print lone surrogates as replacement characters #42094
Assignees
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Comments
askeksa-google
added
the
area-vm
dart-bot
pushed a commit
that referenced
this issue
May 30, 2020
This test crashes the android test runner, and should be fixed when issue #42094 is rolled to the checked-in SDK. BUG=#42094 Change-Id: I91e5ea5358b08d3776ae485b90aff7cd01d02322 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149580 Reviewed-by: William Hesse <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The recent breaking change described in #41100 changes UTF-8 encoding such that lone surrogates are encoded as replacement characters. However, this change did not extend to the
printimplementation in the VM, which contains its own UTF-8 encoder.This causes the failures seen in https://dart-review.googlesource.com/c/sdk/+/149285 where a test outputs surrogates via
print(which are encoded directly) and the Dart implementation running the test system is updated to treat encoded surrogates as invalid.We should change the UTF-8 encoder used in
print(when not overridden by the embedder) to match the behavior of our Dart UTF-8 encoder.The text was updated successfully, but these errors were encountered: