Skip to content

Fix the versioning of Dart SDK packages #4352

Closed
@nex3

Description

@nex3

We used to use the /revision file in the Dart SDK to determine the version of the packages contained within, but that file has apparently disappeared. We should generate the version from the timestamp on the /create.stamp file instead.

Activity

devoncarew

devoncarew commented on Aug 3, 2012

@devoncarew
Member

I still see this file as existing in the latest continuous builds (http://gsdview.appspot.com/dart-editor-archive-continuous/latest/). What archive is it missing from?

sethladd

sethladd commented on Aug 3, 2012

@sethladd
Contributor

I made a local build, straight from source, using ./tool/build.py -m release The output dir, xcodebuild/ReleaseIA32/dart-sdk is what I point DART_SDK to.

I suspect our build process only uses "svn info", and it should use "git svn info" if "svn info" isn't working.

munificent

munificent commented on Aug 17, 2012

@munificent
Member

Added this to the M1 milestone.

nex3

nex3 commented on Sep 5, 2012

@nex3
MemberAuthor

I'm building from Git, and I have a revision file in my SDK output.

sethladd

sethladd commented on Sep 13, 2012

@sethladd
Contributor

Build script generates a revision file for both svn and git now.


Added Fixed label.

self-assigned this
on Sep 13, 2012
added this to the M1 milestone on Sep 13, 2012
DartBot

DartBot commented on Jun 5, 2015

@DartBot

This issue has been moved to dart-lang/pub#57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @nex3@sethladd@munificent@devoncarew@DartBot

      Issue actions

        Fix the versioning of Dart SDK packages · Issue #4352 · dart-lang/sdk