Skip to content

Address performance regression introduced in 63d17b0 #44799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a-siva opened this issue Jan 28, 2021 · 7 comments
Closed

Address performance regression introduced in 63d17b0 #44799

a-siva opened this issue Jan 28, 2021 · 7 comments
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on
Milestone
February Beta Rel...

Comments

@a-siva
Copy link
Contributor

a-siva commented Jan 28, 2021

Address performance regression introduced in 63d17b0
(Please see flutter/flutter#73794 for more details)

This issue has been created to track the Dart side changes to address the regression.
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution labels Jan 28, 2021
@a-siva a-siva added this to the January Beta Release (2.12) milestone Jan 28, 2021
@a-siva a-siva mentioned this issue Jan 28, 2021
Closed
@a-siva
Copy link
Contributor Author

a-siva commented Jan 28, 2021

https://dart-review.googlesource.com/c/sdk/+/181542 is the CL to revert the changes (63d17b0 and 0bf8d38).

@a-siva a-siva self-assigned this Jan 28, 2021
@a-siva
Copy link
Contributor Author

a-siva commented Jan 29, 2021

https://dart-review.googlesource.com/c/sdk/+/181542 has landed

@mit-mit
Copy link
Member

mit-mit commented Jan 29, 2021

Is this still a P0 now that the revert has landed?

@a-siva
Copy link
Contributor Author

a-siva commented Jan 29, 2021

I wanted it to be a P0 until I got the cherry pick request into the beta branch completed.

@a-siva
Copy link
Contributor Author

a-siva commented Jan 29, 2021

A cherry pick request for this change into the beta branch has been created #44807,

lowering the priority and changing the milestone to reflect the forward fix that @rmacnak-google is working on.

@a-siva a-siva added P2 A bug or feature request we're likely to work on and removed P0 A serious issue requiring immediate resolution labels Jan 29, 2021
@a-siva a-siva assigned rmacnak-google and unassigned a-siva Jan 29, 2021
@franklinyow
Copy link
Contributor

@rmacnak-google Any update? Are we on track for Feb. milestone?

@a-siva
Copy link
Contributor Author

a-siva commented Feb 22, 2021

The revert addressed this performance issue and other changes will be tracked in #41974

@a-siva a-siva closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
February Beta Release
Development

No branches or pull requests
4 participants
@rmacnak-google @a-siva @mit-mit @franklinyow