Skip to content

[CP][Beta] - Revert changes that cause performance regression in Flutter benchmark #44807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a-siva opened this issue Jan 29, 2021 · 5 comments
Closed

[CP][Beta] - Revert changes that cause performance regression in Flutter benchmark #44807

a-siva opened this issue Jan 29, 2021 · 5 comments
Assignees
@athomas
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Milestone
January Beta Rele...

Comments

@a-siva
Copy link
Contributor

a-siva commented Jan 29, 2021 •
edited
Loading

Please cherry pick 27deca1 into the beta branch

Reason : We had a performance regression in one of the Flutter benchmarks, please see
flutter/flutter#73794

Impact: The change is a revert of two CLs 0bf8d38 and 63d17b0.
The change has landed in master and has been rolled into Flutter framework without any issues.

The change merges cleanly into the beta branch and builds fine.

Risk: Low, has been merged into master and rolled into Flutter

Link to original issue flutter/flutter#73794

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @sigmundch
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. merge-to-beta cherry-pick-review Issue that need cherry pick triage to approve labels Jan 29, 2021
@a-siva a-siva mentioned this issue Jan 29, 2021
Closed
@a-siva a-siva changed the title [Cherry Pick] - Please Cherry Pick 27deca1457ad6b79eb3d22f16ab45b30b754e2eb into the 2.12 Beta branch [CP][Beta] - Please Cherry Pick 27deca1457ad6b79eb3d22f16ab45b30b754e2eb into the 2.12 Beta branch Jan 29, 2021
@vsmenon
Copy link
Member

vsmenon commented Jan 29, 2021

lgtm

@vsmenon
Copy link
Member

vsmenon commented Jan 29, 2021

fyi - @pcsosinski

@pcsosinski
Copy link

lgtm

@franklinyow franklinyow changed the title [CP][Beta] - Please Cherry Pick 27deca1457ad6b79eb3d22f16ab45b30b754e2eb into the 2.12 Beta branch [CP][Beta] - Revert changes that cause performance regression in Flutter benchmark Jan 30, 2021
@franklinyow
Copy link
Contributor

Approved

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Jan 30, 2021
@athomas
Copy link
Member

athomas commented Feb 2, 2021

Merged to beta with e5dd92c (2.12.0-259.8.beta).

@athomas athomas closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-beta
Projects
None yet
Milestone
January Beta Release (2.12)
Development

No branches or pull requests
5 participants
@vsmenon @a-siva @athomas @franklinyow @pcsosinski