Skip to content

Implement non-function type alias support in the VM/AOT #44954

Closed
@leafpetersen

Description

@leafpetersen

This issue tracks support of the non-function type alias feature. See the enclosing meta-issue for details.

I don't expect much work here, but we should validate that debugging/error messages work as desired, and that the backend doesn't choke.

cc @a-siva @mkustermann @mraleph @eernstg @mit-mit @franklinyow

Activity

added
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
on Feb 11, 2021
a-siva

a-siva commented on Feb 19, 2021

@a-siva
Contributor

As indicated by you there is no work in the VM for implementing this feature as the front end will account for substituting the type alias.
With regards to debugging/error messages working as desired, what is the expectation? I believe currently for all typedefs the VM only shows the substituted type, this is probably true for DDC too.

leafpetersen

leafpetersen commented on Feb 19, 2021

@leafpetersen
MemberAuthor

I have no particular expectations, this issue is just to provide a sign off point for us to validate that the backend doesn't choke, and that any desired functionality is implemented.

I think that showing the substituted type in error messages is fine.

I don't know how much of these are directly VM related, but things that I can imagine being worth validating:

  • Hot reload works in a reasonable manner if a typedef is edited, or a use of a typedef is edited
  • Debugging works in a reasonable manner (i.e. doesn't crash)
  • Global type optimizations aren't confused by uses of typedefs (if everything gets substituted away early, that should be trivially true)

Basically, whenever you're comfortable with the native backend support for this feature, feel free to close this out.

leafpetersen

leafpetersen commented on Mar 12, 2021

@leafpetersen
MemberAuthor

@a-siva should I close this out or is there any work we have planned here?

a-siva

a-siva commented on Mar 13, 2021

@a-siva
Contributor

I had it open just to ensure that the tests passed once CFE completed the implementation.

a-siva

a-siva commented on Mar 22, 2021

@a-siva
Contributor

Closing this as no work is necessary in the VM, we will track all individual test failures by opening fresh issues for each failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.language-nonfunction-type-aliasesIssues related to non-function type aliases

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @leafpetersen@a-siva@eernstg

      Issue actions

        Implement non-function type alias support in the VM/AOT · Issue #44954 · dart-lang/sdk