Skip to content

Please triage CompileTimeErrors on co19/LanguageFeatures/Constructor-tear-offs tests #46882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexmarkov opened this issue Aug 11, 2021 · 3 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@alexmarkov
Copy link
Contributor

As of today, there are 16 CompileTimeError and 10 MissingCompileTimeError on co19/LanguageFeatures/Constructor-tear-offs tests in cfe-strong-linux configuration (16 CompileTimeError and 2 MissingCompileTimeError on dartk-strong-linux-release-x64).

Repro:

tools/test.py -n cfe-strong-linux co19/LanguageFeatures/Constructor-tear-offs

Those could be mistakes in the tests or bugs in CFE. Potentially they could also hide problems in the back-ends which we won't discover until CompileTimeErrors are fixed.

/cc @johnniwinther @eernstg

@alexmarkov alexmarkov added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). legacy-area-front-end Legacy: Use area-dart-model instead. labels Aug 11, 2021
@johnniwinther
Copy link
Member

cc @stefantsov

@eernstg
Copy link
Member

eernstg commented Aug 12, 2021

Commit f9a6563 was a co19 roll where approximately 65 co19 commits were carried over (that is: lots of changes happened), and dart-lang/co19#1138 was created in order to triage and handle the failures (we had about 107 test failures when that issue was created). So the work is ongoing.

I'm currently looking at those 26 cases.

@eernstg
Copy link
Member

eernstg commented Aug 12, 2021

Created dart-lang/co19#1145 .. dart-lang/co19#1157 about tests with issues. Created #46887 .. #46891 about issues in tools revealed by the new tests. Created dart-lang/language#1802 about a specification clarification issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Development

No branches or pull requests

3 participants