-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[dart2js] Implement support for dynamic checks on parameters that are covariant-by-declaration due to inheritance #47076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rakudrama (or @sigmundch) - can you provide a very rough estimate of how long this would take to do? We're trying to get breadbox estimates of the ~5 impl. tasks for this language change. (updated to reference the correct github account) |
@rakudrama (our apologies for the spam @sra) |
It would be useful to have a sketch of how the CFE will present the additional checks. |
I'm working on a CL that'll add explicit |
@sigmundch - can you assign the right owner for this? Thanks! |
Thanks @devoncarew, will follow up shortly after our team sync. @johnniwinther - are the CFE representation changes in place? |
quick update - @johnniwinther will be looking first at whether the lowering in the CFE needs any additional work, and will reassign it to us once it's ready for us to take a look. |
This is the dart2js specific issue for #47072, which has the details.
The text was updated successfully, but these errors were encountered: