Skip to content

Write language tests for generic function instantiation of existing function objects in constants #47155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eernstg opened this issue Sep 8, 2021 · 2 comments
Closed

Write language tests for generic function instantiation of existing function objects in constants #47155

eernstg opened this issue Sep 8, 2021 · 2 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@eernstg
Copy link
Member

eernstg commented Sep 8, 2021

This is the test specific issue for #47150, which has the details.
@eernstg eernstg added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Sep 8, 2021
@eernstg eernstg mentioned this issue Sep 8, 2021
Closed
6 tasks
@eernstg
Copy link
Member Author

eernstg commented Sep 10, 2021

Constant type literal instantiations are already tested in language/typedef/aliased_type_literal_instantiation_test.dart (which has plain type literal constants as well as aliased ones). This test fails on analyzer-asserts-* configurations, but otherwise passes.

Tests about generic function instantiations are added in https://dart-review.googlesource.com/c/sdk/+/213047.

@eernstg
Copy link
Member Author

eernstg commented Sep 17, 2021

Tests landed as 60d8781.

@eernstg eernstg closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eernstg