Skip to content

Update test to allow type variable type literals as potential constants #47274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnniwinther opened this issue Sep 23, 2021 · 2 comments
Closed

Update test to allow type variable type literals as potential constants #47274

johnniwinther opened this issue Sep 23, 2021 · 2 comments
Assignees
@eernstg
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@johnniwinther
Copy link
Member

The tests

language/constants_2018/constant_types_test/04 Pass (expected CompileTimeError)

needs to be updated when dart-lang/language#1860 has landed
@johnniwinther johnniwinther added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Sep 23, 2021
@eernstg
Copy link
Member

eernstg commented Sep 27, 2021

Cf. https://dart-review.googlesource.com/c/sdk/+/214644.

@eernstg
Copy link
Member

eernstg commented Sep 28, 2021

Said tests landed as 117d1b7.

@eernstg eernstg closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eernstg eernstg

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eernstg @johnniwinther