-
Notifications
You must be signed in to change notification settings - Fork 213
Add support for a type variable as a potentially constant expression #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
approved these changes
Sep 23, 2021
accepted/future-releases/constructor-tearoffs/feature-specification.md
Outdated
Show resolved
Hide resolved
63d2a6d
to
8610bc1
Compare
eernstg
commented
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review response.
accepted/future-releases/constructor-tearoffs/feature-specification.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra kind of potentially constant expression, namely a type variable (which is necessarily declared by the enclosing class).
It is needed for consistency, because this is a semantics that we can already express using different mechanisms:
The PR also moves one more kind of constant to the section about constant expressions, such that this section contains every kind of constant / potentially constant expression in this document which is not derived directly from the corresponding constructor function.
The ones that are based on the corresponding constructor function remain where they are, because it would duplicate a lot of material to refer to the details of the declaration of said functions in the constant expression section. The commentary that creates the connection has been updated accordingly.