Skip to content

Implement WeakReference, Finalizer in dart2js #47775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #47772
mraleph opened this issue Nov 25, 2021 · 4 comments
Closed
Tracked by #47772

Implement WeakReference, Finalizer in dart2js #47775

mraleph opened this issue Nov 25, 2021 · 4 comments
Assignees
@rileyporter
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop web-dart2js
Milestone
February Release ...

Comments

@mraleph
Copy link
Member

mraleph commented Nov 25, 2021

No description provided.

@mraleph mraleph mentioned this issue Nov 25, 2021
Closed
6 tasks
@mraleph mraleph added area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop web-dart2js labels Nov 25, 2021
@devoncarew
Copy link
Member

@sigmundch - who's a likely owner here?

@sigmundch
Copy link
Member

I'll follow up shortly on the owner (same with ddc). Most likely this will be the same person, since the implementation is likely to be the same for both.

@dcharkes
Copy link
Contributor

@lrhn suggested that if detach is omitted in Finalizer.attach we use value as the detach object.

I'll update the documentation in the VM CL, but of course it should be implemented as such in Dart2JS as well then.

https://dart-review.googlesource.com/c/sdk/+/229544/8/sdk/lib/core/weak.dart#185

copybara-service bot pushed a commit that referenced this issue Feb 8, 2022
@rileyporter
Add WeakReference and Finalizer patches for ddc and dart2js
278a040 
Routes implementation to JavaScript WeakRef and
FinalizerRegistry APIs using JS foreign function calls. Uses
Wrapper names for the Dart library to avoid issues with DDC.

Bug: #47775, #47776
Change-Id: Iad82bd83ac10c666d08a2c042a8ed6109b8b58c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229180
Reviewed-by: Stephen Adams <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Reviewed-by: Nicholas Shahan <[email protected]>
Commit-Queue: Riley Porter <[email protected]>
@rileyporter
Copy link
Contributor

dart2js implementation landed in 278a040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rileyporter rileyporter

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop web-dart2js
Projects
None yet
Milestone
February Release (Dart 2.17 beta 2)
Development

No branches or pull requests
5 participants
@mraleph @devoncarew @sigmundch @rileyporter @dcharkes