co19/LanguageFeatures/FinalizationRegistry/no_ffi/Finalizer/noSuchMethod_A01_t01 crash

[eernstg]

Said test causes a crash on the following configurations, cf. dart-lang/co19#1316:

dartk-strong-linux-debug-x64
dartk-strong-linux-release-simarm
dartk-strong-linux-release-simarm64
dartk-strong-linux-release-x64
dartk-strong-win-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-simarm
dartk-weak-asserts-linux-release-simarm64
dartk-weak-asserts-linux-release-x64
dartk-weak-asserts-win-release-x64
dartkp-strong-linux-debug-x64
dartkp-strong-linux-release-simarm64
dartkp-strong-linux-release-x64
dartkp-strong-mac-release-simarm64
dartkp-strong-win-release-x64
dartkp-weak-asserts-linux-debug-x64
dartkp-weak-asserts-linux-release-simarm64
dartkp-weak-asserts-linux-release-x64
dartkp-weak-asserts-mac-release-simarm64
dartkp-weak-asserts-win-release-x64

Here is an example stack trace:

Unhandled exception:
Expect.throws(): Unexpected UnimplementedError(UnimplementedError: Finalizer)
#0      new Finalizer (dart:core-patch/expando_patch.dart:198)
#1      finalizer (file:///C:/b/s/w/ir/tests/co19/src/LanguageFeatures/FinalizationRegistry/no_ffi/Finalizer/noSuchMethod_A01_t01.dart:16)
#2      main.<anonymous closure> (file:///C:/b/s/w/ir/tests/co19/src/LanguageFeatures/FinalizationRegistry/no_ffi/Finalizer/noSuchMethod_A01_t01.dart)
#3      Expect.throws (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect_common.dart:186)
#4      main (file:///C:/b/s/w/ir/tests/co19/src/LanguageFeatures/FinalizationRegistry/no_ffi/Finalizer/noSuchMethod_A01_t01.dart:19)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297)
#6      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192)

#0      _fail (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect.dart:18)
#1      Expect.throws (file:///C:/b/s/w/ir/tests/co19/src/Utils/expect_common.dart:189)
#2      main (file:///C:/b/s/w/ir/tests/co19/src/LanguageFeatures/FinalizationRegistry/no_ffi/Finalizer/noSuchMethod_A01_t01.dart:19)
#3      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192)

[dcharkes]

We haven't landed the implementation in the VM yet.

[eernstg]

@dcharkes, I created these issues (#48573, #48574, #48575) because they don't have the same failing configurations, so it thought it could be ongoing work. However, it sounds like you'd prefer to avoid having issues like this. Would it be a safe bet that UnimplementedError should never be reported as an issue as long as the given feature is likely to be unfinished?

[dcharkes]

I prefer to take a look at the 'current status' after landing the CL and then triage them all in one go instead of looking at deltas before landing.

[eernstg]

Sounds like "yes, that is safe"? ;)

[a-siva]

'March Release' milestone ?