Skip to content

Add --warn-on-legacy-js-interop flag to JS compilers (dart2js & DDC) #50665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Dec 8, 2022 · 4 comments
Closed

Add --warn-on-legacy-js-interop flag to JS compilers (dart2js & DDC) #50665

kevmoo opened this issue Dec 8, 2022 · 4 comments
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. dds-core Issues related to the core functionality of DDS web-dart2js

Comments

@kevmoo
Copy link
Member

kevmoo commented Dec 8, 2022

Talking to @srujzs about this.

We should let folks OPT-IN to getting warnings here. We can use this on critical packages, etc in the short term to start pushing folks towards wasm-compatible JS-interop model.

CC @sigmundch ... and @joshualitt

@kevmoo kevmoo added web-dart2js area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. dds-core Issues related to the core functionality of DDS labels Dec 8, 2022
@rakudrama
Copy link
Member

Could this be a lint? That has everything needed to manage opt-in.

@kevmoo
Copy link
Member Author

kevmoo commented Dec 8, 2022

@rakudrama – great idea! I'd take it.

The only issue with a lint: it's not reported for ALL CODE.

I want to be able to compile https://gallery.flutter.dev/ – or some other big app – and see all of the spots that would need to get fixed to run w/ wasm (at least in theory)

@kevmoo
Copy link
Member Author

kevmoo commented Dec 8, 2022

See also #58957

@kevmoo
Copy link
Member Author

kevmoo commented Jul 11, 2024

Going to go with the lint idea. It's cleaner.

@kevmoo kevmoo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. dds-core Issues related to the core functionality of DDS web-dart2js
Projects
None yet
Development

No branches or pull requests

2 participants