Skip to content

proposal: legacy_js_interop #58957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kevmoo opened this issue Dec 8, 2022 · 4 comments
Open

proposal: legacy_js_interop #58957

kevmoo opened this issue Dec 8, 2022 · 4 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-lint-proposal linter-status-pending P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@kevmoo
Copy link
Member

kevmoo commented Dec 8, 2022

legacy_js_interop

Description

Warn on all usage of "legacy" JS-interop features that are not compatible w/ dart2wasm

Details

See #50665

Will need to pull in @srujzs or similar for all details

Kind

Guards against errors when targeting dart2wasm

Bad Examples

TBD – using dart:js features, dart:html

Good Examples

Using new JS interop features TBD

Discussion

See #50665
@kevmoo kevmoo mentioned this issue Dec 8, 2022
Closed
@mnordine
Copy link
Contributor

mnordine commented Dec 8, 2022 •
edited
Loading

"legacy" JS-interop features that are not compatible w/ dart2wasm

What features are these?

@kevmoo
Copy link
Member Author

kevmoo commented Dec 8, 2022

@mnordine – we're not quite ready to enumerate them. We're hoping to have a story outlined by end-of-January

@jodinathan
Copy link

@kevmoo I think js_bindings is a good way to avoid dart:js and dart:html.

Please, tell us if you need us to change anything in the lib to make it comp to this new wasm/js standard.

@kevmoo kevmoo mentioned this issue Dec 15, 2022
Closed
@pq pq added the P3 A lower priority bug or feature request label May 22, 2023
@sigmundch sigmundch mentioned this issue Nov 9, 2023
Open
37 tasks
@parlough
Copy link
Member

parlough commented Dec 18, 2023 •
edited
Loading

An alternative, but a bit stricter, proposal: #54347

@parlough parlough mentioned this issue Jan 12, 2024
Merged
1 task
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Mar 27, 2024
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-linter Issues with the analyzer's support for the linter package linter-lint-proposal linter-status-pending P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kevmoo @pq @srawlins @devoncarew @mnordine @bwilkerson @jodinathan @parlough