Skip to content

Remove old fields from analysis_options.yaml #50680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srawlins opened this issue Dec 10, 2022 · 4 comments
Closed

Remove old fields from analysis_options.yaml #50680

srawlins opened this issue Dec 10, 2022 · 4 comments
Assignees
@srawlins
Labels
analyzer-analysis-options legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Milestone
Dart 3 alpha 1

Comments

@srawlins
Copy link
Member

srawlins commented Dec 10, 2022 •
edited
Loading

I see support in analyzer's AnalysisOptions class, support for:

We could remove at least enableSuperMixins, enablePreviewDart2, and strong-mode. Not sure about optional-checks or propagate-linter-exceptions.
@srawlins
Copy link
Member Author

We have already deprecated enableSuperMixins (with AnalysisOptionsHintCode.SUPER_MIXINS_SETTING_DEPRECATED) and enablePreviewDart2 (with AnalysisOptionsHintCode.PREVIEW_DART_2_SETTING_DEPRECATED).

@srawlins
Copy link
Member Author

cc @pq do you know what propagate-linter-exceptions is?

@pq
Copy link
Member

pq commented Dec 12, 2022

Yeah. This is something @stereotype441 added to improve internal builds and testing (more context: https://dart-review.googlesource.com/c/sdk/+/208141).

@srawlins
Copy link
Member Author

Ok cool, we'll keep it!

copybara-service bot pushed a commit that referenced this issue Dec 13, 2022
@srawlins
Remove all support for super-mixins option
fdf59ad 
Bug: #50680
Change-Id: I96409d02e64d3e198e0fae4a55f58f871ce2aeac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275142
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
@bwilkerson bwilkerson added the P2 A bug or feature request we're likely to work on label Dec 13, 2022
@srawlins srawlins self-assigned this Dec 13, 2022
@srawlins srawlins added this to the Dart 3 alpha 1 milestone Dec 13, 2022
copybara-service bot pushed a commit that referenced this issue Dec 15, 2022
@srawlins
Revert "Remove preview-dart-2 option in analysis options"
6d05f24 
This reverts commit f30e5de.

Reason for revert: https://dart-review.googlesource.com/c/sdk/+/274921 broke customer test, and this CL sits right on top of it.

Original change's description:
> Remove preview-dart-2 option in analysis options
>
> Fixes #50680
>
> AnalysisOptionsHintCode is moved from generated `option_codes.g.dart` to `option_codes.dart`, for non-generated diagnostics:
>
> * AnalysisOptionsHintCode.DEPRECATED_LINT_HINT and
> * AnalysisOptionsHintCode.DUPLICATE_RULE_HINT
>
> Change-Id: I131fb2901fca26ff971b6c9c519ab2f0b983a65c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275500
> Reviewed-by: Brian Wilkerson <[email protected]>
> Commit-Queue: Samuel Rawlins <[email protected]>
> Reviewed-by: Konstantin Shcheglov <[email protected]>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia417aa5edc5b279a5fced43154de4cd5c9d3be2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276023
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 20, 2022
@srawlins
Revert "Revert "Remove preview-dart-2 option in analysis options""
e38a704 
This reverts commit 6d05f24.

Fixes #50680

Change-Id: I6f0d177708d88a4cfd52710684642d03fee8743a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276761
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@bartekpacia bartekpacia mentioned this issue Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
analyzer-analysis-options legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart 3 alpha 1
Development

No branches or pull requests
3 participants
@pq @srawlins @bwilkerson