update CONVERT_TO_SWITCH_EXPRESSION to handle cases w/o breaks

[pq]

Example:

enum E { e1, e2 }

f(E e) {
  var v;
  switch (e) {
    case E.e1:
      v = 'e1';
    case E.e2:
      v = 'e2';
  }
}

should convert to:

enum E { e1, e2 }

f(E e) {
  var v = switch (e) {
    E.e1 => 'e1',
    E.e2 => 'e2',
  };
}

/fyi @bwilkerson @johnpryan @MaryaBelanger

[bernaferrari]

Hey, does your thing work with this?

switch (textDirection) {
  case TextDirection.rtl:
    borderRadius = indicatorBorderRadius.copyWith(topRight: Radius.zero, bottomRight: Radius.zero);
  case TextDirection.ltr:
    borderRadius = indicatorBorderRadius.copyWith(topLeft: Radius.zero, bottomLeft: Radius.zero);
}

The borderRadius declaration is far away, I still wish the end result were borderRadius = switch(...).

[pq]

Hey @bernaferrari! That should work just fine. When this lands, you should get an assist that produces:

borderRadius = switch (textDirection) {
  TextDirection.rtl => indicatorBorderRadius.copyWith(topRight: Radius.zero, bottomRight: Radius.zero),
  TextDirection.ltr => indicatorBorderRadius.copyWith(topLeft: Radius.zero, bottomLeft: Radius.zero)
}

(Regardless of how distant the declaration of borderRadius is.)

If you hit any snags, do let us know!

[bernaferrari]

Hey @pq, another question, what about this code? Is there a way to convert to => while preserving the assert? That's more like a curiosity, hehe. Thanks!

switch (textDirection) {
  case TextDirection.rtl:
    borderRadius = indicatorBorderRadius.copyWith(topRight: Radius.zero, bottomRight: Radius.zero);
  case TextDirection.ltr:
    assert('something');
    borderRadius = indicatorBorderRadius.copyWith(topLeft: Radius.zero, bottomLeft: Radius.zero);
}