JSON parsing in frog is broken

[DartBot]

This issue was originally filed by jeffbailey@google.com

---

import("dart:json")

var a = "[1,2,3]"
var b = JSON.parse(a)

What is the expected output? What do you see instead?

b should now contain an array. With the dart editor, it does. With frog, it does not.

What version of the product are you using? On what operating system?

jeffbailey@cirrostratus:~/Programming/gclienttree/dart/dart$ svn info
Path: .
URL: http://dart.googlecode.com/svn/trunk/dart
Repository Root: http://dart.googlecode.com/svn
Repository UUID: 260f80e4-7a28-3924-810f-c04153c831b5
Revision: 1647
Node Kind: directory
Schedule: normal
Last Changed Author: dgrove@google.com
Last Changed Rev: 1556
Last Changed Date: 2011-11-15 17:11:21 -0800 (Tue, 15 Nov 2011)

Please provide any additional information below.

[DartBot]

This comment was originally written by jimhug@google.com

---

Thanks for the report. It looks like this is another corner that has fallen over due to lack of testing. We should get this resolved very soon.

FYI - We are using slightly different binding to JS in frog vs. dartc and as a result we do need a different version of this file. Our ultimate goal for frog is to make this kind of code work without any need for the weird shenanigans that this code is going through.

---

Added Area-Frog, Triaged labels.

[DartBot]

This comment was originally written by jeffbailey@google.com

---

Wonderful, thanks! Having found both copies, I may patch in a quick fix to this so that I'm unstuck for weekend hacking. Would that be useful to post here if I do?

[DartBot]

This comment was originally written by jimhug@google.com

---

Sure, patches are always welcome - so long as we get to decide whether to accept or just do it our own way <smile>.

Have fun with your weekend hacking! - Jim

[DartBot]

This comment was originally written by jeffbailey@google.com

---

The best part about you having commit access and not me is that you get to make that decision.

However, I hope you'll find this patch sufficiently straightforward:

Index: frog/lib/json.js
===================================================================

--- frog/lib/json.js (revision 1684)
+++ frog/lib/json.js (working copy)
@@ -23,6 +23,7 @­@
   if (obj != null && typeof obj == 'object' && !(obj instanceof Array)) {
     return $fixupJsObjectToDartMap(obj);
   }

• return obj;
   }
   
   // Converts the parsed JavaScript Object into a Dart Map.

[DartBot]

This comment was originally written by jimhug@google.com

---

http://codereview.chromium.org/860401

Thanks for the clear report and the simple fix!

---

Added Fixed label.