Skip to content

[dart2wasm] Implement NativeFinalizer #52261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcharkes opened this issue May 4, 2023 · 4 comments
Closed

[dart2wasm] Implement NativeFinalizer #52261

dcharkes opened this issue May 4, 2023 · 4 comments
Labels
area-dart2wasm Issues for the dart2wasm compiler.

Comments

@dcharkes
Copy link
Contributor

dcharkes commented May 4, 2023

For context: the VM implementation is inside the GC, and the relevant standard libraries and patch files interact with that.

I have no idea what the primitives in WASMGC are that can be used to do this.

Filing a tracking bug so we can point somewhere.
@dcharkes dcharkes added the area-dart2wasm Issues for the dart2wasm compiler. label May 4, 2023
@askeksa-google
Copy link

Finalizer was implemented in https://dart-review.googlesource.com/c/sdk/+/279718

@dcharkes dcharkes changed the title [dart2wasm] Implement Finalizer and NativeFinalizer [dart2wasm] Implement NativeFinalizer May 4, 2023
copybara-service bot pushed a commit that referenced this issue May 10, 2023
@dcharkes
[vm/ffi] Pointer.asTypedList finalizer
e5bb28b 
TEST=tests/ffi/external_typed_data_finalizer_test.dart

Closes: #50507
CoreLibraryReviewExempt: #52261
Change-Id: I1a82dcca15961b28c0de64637970fe38a39286e5
Cq-Include-Trybots: luci.dart.try:vm-asan-linux-release-x64-try,vm-aot-asan-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-qemu-linux-release-arm-try,vm-win-debug-x64-try,vm-win-debug-x64c-try,vm-aot-win-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-aot-mac-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301001
Commit-Queue: Daco Harkes <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>
@mkustermann
Copy link
Member

We don't officially support dart:ffi for end users (will make it an error for 3rd parties soon). I'm going to close this in favor of the more general Implement dart:ffi for the web.

@dcharkes
Copy link
Contributor Author

will make it an error for 3rd parties soon

@mkustermann That would break the current workflow for the FFIgenpad project. Maybe we should put it behind an experiment flag instead of hard disallowing it?

@mkustermann
Copy link
Member

@mkustermann That would break the current workflow for the FFIgenpad project. Maybe we should put it behind an experiment flag instead of hard disallowing it?

Let's have that discussion offline (what FFIgenpad is, what it wants to do and how to best do it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dart2wasm Issues for the dart2wasm compiler.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcharkes @mkustermann @askeksa-google